Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed contextmenu test spec with scrolling window by arrow down #6449

Merged
merged 1 commit into from Nov 12, 2019

Conversation

@swistach
Copy link
Contributor

swistach commented Nov 12, 2019

Fixed contextmenu test spec with scrolling window by arrow down

Context

On bigger screens, context menu in ContextMenu > keyboard navigation > no item selected > should scroll down, when the user hits ARROW_DOWN for an item in the menu below the viewport test spec will not increase the viewport. I added the top margin to be sure that the context menu will generate additional scrollable space.

How has this been tested?

Run ContextMenu > keyboard navigation > no item selected > should scroll down when the user hits ARROW_DOWN for an item in the menu below the viewport test spec in a browser (Chrome, Firefox or Opera).

Types of changes

  • Bugfix (a non-breaking change which fixes an issue)
…om edge of viewport - on bigger screens than it is in puppeter configuration it might be different.
@swistach swistach added this to the November 2019 milestone Nov 12, 2019
@swistach swistach requested a review from jansiegel Nov 12, 2019
@jansiegel jansiegel assigned swistach and unassigned jansiegel Nov 12, 2019
@swistach swistach merged commit 6b8bde3 into develop Nov 12, 2019
4 checks passed
4 checks passed
continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (krzysztofspilka) No manifest changes detected
@swistach swistach deleted the fix-contextmenu-test-arrow-down branch Nov 12, 2019
swistach added a commit that referenced this pull request Nov 12, 2019
…om edge of viewport - on bigger screens than it is in puppeter configuration it might be different. (#6449)
swistach added a commit that referenced this pull request Nov 12, 2019
…om edge of viewport - on bigger screens than it is in puppeter configuration it might be different. (#6449)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.