Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add CodeSandbox CI to our PR workflow #6565
CodeSandbox CI bot should follow the link to the issue, get the example and build it with newer HoT version. It should also take three examples from the config file and create new forks.
And as a developer I attach another example: https://codesandbox.io/s/amazing-cohen-9elvv
How has this been tested?
It is a test
Types of changes
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 051bd14:
I think I've found the issue. CodeSandbox has a problem with loading
In earlier versions of
In that case, CodeSandbox should omit
To move forward with this PR and don't wait for CodeSandbox (this is an edge case so they can ignore it for a long time) and I'm not sure if that will solve the issue (let's say we load latest
@budnix Do you think it will work with a simple package update for
Maybe we could update the
However, I have a few questions already:
You're never alone! But it works for me. FF 72.0.1, OS X 10.15.
15 sec on Chrome and Firefox for the first run. Then 3 sec witch cached sandboxes. I'm affraid it's up to them and I think they're doing quite well. Remember that everything has to be download from npm and build with webpack.
IMO It's still faster than recreating every use case example in JSFiddle with each new build. And would help @aninde and the reviewers a lot.
I'm not aware of such a feature. CodeSandbox UI supports already build and published packages. But since CodeSandbox CI already does it for each commit it should be possible with the instructions in an answer to your 10th question.
One is taken from the configuration (see files in this PR) and the second one is taken from the PR comment. I was lazy while creating this PR and made a copy&paste example with a small change. They should be quite different in a real-life use case.
Sources for "Configuration" sandboxes are taken from this repo: https://github.com/handsontable/examples and are configured in
"Configuration" sandboxes are taken from the
"PR" sandboxes are the ones that bot found in the PR. They are PR specific. Those could be use cases that the developer used to implement/demonstrate the feature or bug fix.
One type is missing in this PR and it's called "Issue". Those are the sandboxes that we're found by the bot in the issue that was mentioned in the PR comment. If there we're a use case scenarios reported there by the user, quality assurance or project manager (among others) within the issue we're fixing in the PR we will be able to verify that the original use case scenario was fixed as well.
Unfortunately no. It might be a good feature request.
We would have to add tests to sandboxes in https://github.com/handsontable/examples. It's more for adding additional tests for a particular example than running our tests suite again. The tests we're already run with Codeship CI.
Yes. Instructions are available here: https://ci.codesandbox.io/status/handsontable/handsontable/pr/6565/builds/4801
My proposal of advanced, but also universal settings: