Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hot logo to the repo with demo screenshot #6609

Merged
merged 7 commits into from Jan 9, 2020
Merged

Conversation

@budnix
Copy link
Member

budnix commented Jan 9, 2020

Context

Add the Handsontable logo (SVG) and demo screenshot to the repository.

The screenshot file is twice as big in size as the img tag width declares. This makes the image sharp on retina devices (at least those that support screen size x2). I've tried implementing through img.srcset but it seems that GH MD doesn't support that. This only works for GH layout, for the NPM page (https://www.npmjs.com/package/handsontable) it will be still blurred as it is right now.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. #6465

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation.
budnix added 6 commits Jan 9, 2020
@wojciechczerniak wojciechczerniak mentioned this pull request Jan 9, 2020
64 of 127 tasks complete
@budnix budnix merged commit eece054 into develop Jan 9, 2020
2 checks passed
2 checks passed
continuous-integration/codeship Build succeeded
Details
security/snyk - package.json (krzysztofspilka) No manifest changes detected
@budnix budnix deleted the feature/logo-and-screenshot branch Jan 9, 2020
@budnix budnix mentioned this pull request Jan 9, 2020
1 of 6 tasks complete
jansiegel added a commit that referenced this pull request Feb 3, 2020
@aninde

This comment has been minimized.

Copy link

aninde commented Feb 7, 2020

Testing notes for release of 7.4.0
LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.