Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump moment, pikaday and numbro to the latest version #6610

Merged
merged 3 commits into from Jan 14, 2020
Merged

Bump moment, pikaday and numbro to the latest version #6610

merged 3 commits into from Jan 14, 2020

Conversation

budnix
Copy link
Member

@budnix budnix commented Jan 9, 2020 •
edited by aninde

Context

Bump dependencies:

  • moment to fixed v2.24.0;
  • numbro to fixed v2.1.2;
  • pikaday to fixed v1.8.0;

comparing dist files it seems that after upgrading the handsontable.full.js file is lighter ~20kB.

How has this been tested?

  • Build a version
  • Check the size of the version
  • Build a version and install with wrappers, check their size
  • Browser e2e tests on Chrome, Firefox, Safari, Opera, Edge
    $ npm run test: e2e.dump
    file is on test/E2ERunner.html
  • Tests walkontable on Chrome, Firefox, Safari, Opera, Edge
    $ test: walkontable.dump
    file is on src/3rdparty/walkontable/test/SpecRunner.html
  • Check the numeric type editor
    • non-integer numbers, currency, commas, number format, formulas
    • repeat above after changing the keyboard language to American
    • and after changing the keyboard language to German
    • IME after changing the language to Chinese or Japanese
  • Click through key functions on a minified version (crud, move, formulas)
  • Click through key functions (crud, move, fixing, formulas) on wrappers
  • Validation check:
    • Has the number of licenses changed?
    • check key with incorrect date - when the license expires yesterday, today and tomorrow

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. Support newer versions of momentjs etc. #5159
  2. 8.0.0 release #6465
  3. #5159 Support newer versions of momentjs etc
  4. #6110 License suggestion for R community: rhandsontable
  5. #5790 RangeError: toFixed() digits arguments must be between 0 and 100
  6. #6582 We're not able to undo changes while using summary calculations and numeric cell data.
  7. #6423 The column type: data is not protected against pasting data using autoFill / fillHandle
  8. #5863 We get Maximum call stack size exceeded when enabling summaryCalculations and minSpareRows
  9. #5569 Numeric Type Does Not Work with Expected to Decimal
  10. #5344 [0.35.1+] Numeric cell type percentage format not calculated
  11. #5251 [3.0.0+] cell invalid after copy paste from excel in version PRO 4.0.0
  12. #4884 Searching uses values hidden by numericFormat
  13. #4396 Numbers parsed incorrectly if "." is thousands separator, "," decimal separator and decimal part not specified
  14. #4360 When changing cell type, cell editor does not dynamically change
  15. #4353 When the cell type is numeric, the formula does not work properly.
  16. #4119 Uncaught TypeError in date cell type with numeric value.
  17. #3402 Alter value before validation
  18. #2966 Cells function gets the property function in the col argument during validation
  19. #5848 Numeric cell type fails to validate -.n

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation.

@budnix budnix marked this pull request as ready for review January 9, 2020 12:58
@budnix budnix requested a review from pnowak January 9, 2020 12:59
@wojciechczerniak wojciechczerniak mentioned this pull request Jan 9, 2020
Closed
204 tasks
@aninde aninde mentioned this pull request Jan 9, 2020
Closed
4 tasks
This was referenced Jan 10, 2020
Closed
Closed
@budnix budnix changed the title Bump moment to (fixed) 2.24.0 Bump moment, pikaday and numbro to the latest version Jan 10, 2020
@aninde aninde mentioned this pull request Jan 10, 2020
Merged
pnowak
pnowak reviewed Jan 10, 2020
View reviewed changes
package.json Show resolved Hide resolved
@pnowak pnowak assigned budnix and unassigned pnowak Jan 10, 2020
@aninde
Copy link
Contributor

aninde commented Jan 10, 2020 •
edited

I added a checklist for testing and some issues that maybe can be fixed. I encourage you to comment and discuss how we can test it better.

@budnix budnix requested a review from aninde January 10, 2020 12:26
@pnowak pnowak self-requested a review January 13, 2020 09:23
pnowak
pnowak approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@pnowak pnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@budnix
Copy link
Member Author

budnix commented Jan 13, 2020

@aninde Please review the PR as soon as you'll be ready. The PR is accepted by @pnowak.

@aninde aninde mentioned this pull request Jan 13, 2020
Closed
@aninde
Copy link
Contributor

aninde commented Jan 13, 2020 •
edited

  1. After npm i there is npm audit

Screenshot 2020-01-13 at 14 19 55

@budnix
Copy link
Member Author

budnix commented Jan 13, 2020

  1. After npm i there is npm audit

Already fixed on the develop branch 4c0bdb0.

@aninde
Copy link
Contributor

aninde commented Jan 14, 2020

I will test this pull request during code freeze.

@budnix
Copy link
Member Author

budnix commented Jan 14, 2020

I will test this pull request during code freeze.

Ok, so I'll merge the changes.

@budnix budnix merged commit f4e68a5 into develop Jan 14, 2020
@budnix budnix deleted the feature/issue-5159 branch January 14, 2020 09:46
jansiegel pushed a commit that referenced this pull request Feb 3, 2020
@budnix @jansiegel
Bump moment, pikaday and numbro to the latest version (#6610)
33e329a 
* Bump moment to (fixed) 2.24.0
* Bump numbro to (fixed) 2.1.2
* Bump pikaday to (fixed) 1.8.0
@AMBudnik
Copy link
Contributor

AMBudnik commented Feb 3, 2020

Just to refer for tests.

Here are the changes for Numbro "numbro": "2.1.1" > "numbro": "2.1.2"

Fix #399: Update dependencies.
Fix #390: Small changes to doc comments.
Fix #328: Fixed unformat for non standard delimiters.

Pikaday "pikaday": "1.5.1" > "pikaday": "1.8.0" (including dependency changes)
https://github.com/Pikaday/Pikaday/releases

@aninde
Copy link
Contributor

aninde commented Feb 3, 2020

Fix #328: Fixed unformat for non standard delimiters.

I reported it for @scarletfog and @jansiegel for RN material.

@aninde aninde mentioned this pull request Feb 3, 2020
Closed
47 tasks
@AMBudnik AMBudnik mentioned this pull request Jul 16, 2020
Closed
@aninde aninde mentioned this pull request Aug 11, 2020
Closed
10 tasks
@aninde
Copy link
Contributor

aninde commented Aug 11, 2020

Tested during code freeze of 7.4.0 handsontable/quality#22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnowak pnowak pnowak approved these changes

@aninde aninde Awaiting requested review from aninde

Assignees

@budnix budnix

Labels
Status: Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@budnix @aninde @AMBudnik @pnowak