Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings objects watcher #108

Closed
wojciechczerniak opened this issue Feb 13, 2019 · 7 comments

Comments

@wojciechczerniak
Copy link
Member

commented Feb 13, 2019

Description

Changing hotSettings attributes will result in an error: "Incorrect value of the columnsRenderCalculator" triggered by Vue watchers. Bug was tracked to:

https://github.com/handsontable/handsontable/blob/65dc03147e411df27e6c2699b93fdc7ade9bad67/src/core.js#L2905

That returns undefined, should have default value of Infinity.

Then Math.min(undefined) returns NaN instead the correct value.

Somewhere in the Vue wrapper we change the default for this.getSettings().maxCols?

Support ticket no68

Steps to reproduce

  1. Try to update hotSettings object with vue-handsontable attribute

Demo

Demo that was provided but was created with old wrapper version:
https://codepen.io/morgenweck/pen/PVjMYx

Example updated to the latest vue-handsontable version and it doesn't work
https://codepen.io/anon/pen/BMPZxG

Your environment

  • Vue wrapper version: 3.1.0
  • Handsontable version: 6.2.2
  • Browser Name and version: Firefox, Chrome
  • Operating System: OS X

@wojciechczerniak wojciechczerniak added this to the March 2019 milestone Feb 13, 2019

@hugobyrne

This comment has been minimized.

Copy link

commented Feb 28, 2019

Is there a fix or workaround for this?
Ive tried rolling back to version 2 in vue but it tells me I need this npm package which doesnt seem to exist
@types/handsontable__vue

@darian314

This comment has been minimized.

Copy link

commented Feb 28, 2019

Any update on when this is going to get fixed?

@AMBudnik

This comment has been minimized.

Copy link

commented Feb 28, 2019

Hey @darian314 we've attached the March milestone, it means that we're planning to fix it in March and publish in April (or faster we get get it done).

@wojciechczerniak

This comment has been minimized.

Copy link
Member Author

commented Feb 28, 2019

@hugobyrne As a workaround it might work to use each option as a prop instead deeply nested settings object.

@morgenweck

This comment has been minimized.

Copy link

commented May 2, 2019

This is now May-- is it fixed?

@wojciechczerniak wojciechczerniak modified the milestones: March 2019, May 2019 May 6, 2019

@wojciechczerniak

This comment has been minimized.

Copy link
Member Author

commented May 6, 2019

@morgenweck Not yet. Sorry, we were blocked longer then we expected. The bug is now resheduled to May and we're back on track to fix it.

@AMBudnik

This comment has been minimized.

Copy link

commented Jul 30, 2019

Hey @hugobyrne @darian314 @morgenweck
we just got it fixed yesterday in v 4.1.0.

@AMBudnik AMBudnik closed this Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.