New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers should not include <iostream> #1

Closed
PeterSommerlad opened this Issue Oct 11, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@PeterSommerlad

PeterSommerlad commented Oct 11, 2017

Including iostream introduces dependecies to the global stream objects, that when used remove unit-testability from code. If i/o functions are implemented include and instead, or only when only declarations of such functions are made.

@hanickadot

This comment has been minimized.

Show comment
Hide comment
@hanickadot

hanickadot Oct 24, 2017

Owner

Fixed in commit d1a7ca4.

Owner

hanickadot commented Oct 24, 2017

Fixed in commit d1a7ca4.

@hanickadot hanickadot closed this Oct 24, 2017

uilianries added a commit to uilianries/compile-time-regular-expressions that referenced this issue Oct 8, 2018

hanickadot#1 Use dynamic project version from Travis branch
- Replace hardcoded version in Conan recipe by
  branch name on Travis CI envs

Signed-off-by: Uilian Ries <uilianries@gmail.com>

hanickadot added a commit that referenced this issue Oct 8, 2018

Merge pull request #11 from uilianries/master
#1 Use dynamic project version from Travis branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment