New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show peer OTR key for old messages #111

Open
infinity0 opened this Issue Nov 27, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@infinity0
Contributor

infinity0 commented Nov 27, 2015

When a contact goes offline, jackline will prefix the older messages with the XMPP resource. It would be good to show the OTR key that those messages were authenticated as, too.

If this makes the prefix too long, you could instead show it once, and wrap the relevant messages in a box:

--- start of previous session with ($OTR_key $XMPP_resource) ---
$time0 $message0
$time1 $message1
etc 
--- end of previous session with ($OTR_key $XMPP_resource) ---
@hannesm

This comment has been minimized.

Owner

hannesm commented Nov 27, 2015

not convinced that this will be useful for most users... and it'll be more output.. there's also not always the case that you're chatting with a single resource, but maybe exchange one message with one resource, then moving to a different resource, etc.

@infinity0

This comment has been minimized.

Contributor

infinity0 commented Nov 27, 2015

the resource that you think you're chatting with can be faked, it's the key that actually identifies the peer who is chatting.

you could instead put it in this line: ***OTR*** encrypted connection established (ssid [xx] xx) - add the full key fingerprint in here, then it's much more obvious who i'm chatting with, if they end the conversation before i get a chance to do /otr info or /fingerprint.

@cfcs

This comment has been minimized.

cfcs commented May 23, 2017

I think this is a sensible idea.
Colorizing them differently (as an additional visual cue) would also be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment