-
Notifications
You must be signed in to change notification settings - Fork 3
Description
as I read the specification (https://otr.cypherpunks.ca/Protocol-v3-4.0.0.html), there can never be a valid receiver instance tag (>= 0x100) in the dh commit message. But some instance messaging clients (in this case coy.im) send some valid instance tag (and they seem to save instance tags in their configuration for whatever reason coyim/coyim#83)...
in short, the sympton is an assertion failure (in builder.ml header, line 36) because ake.ml check_version_instances (third case, Some _ from them, None from us) does not put any instances into the ctx, thus the builder tries to build a v3 header and can't find instance tags.
question which rise: is there harm in not checking any instance tags during dh commit, and just use those we got? (if the other side controls the tags, does it do any harm?) how does the other side react if we decide to choose another one (or send back an error)?