Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define circle radius using 2D vector #163

Merged
merged 1 commit into from Feb 10, 2022
Merged

Define circle radius using 2D vector #163

merged 1 commit into from Feb 10, 2022

Conversation

hannobraun
Copy link
Owner

The 3D definition is kind of wrong. I think all code currently assumes
that circles are in the x-y place[1]. Even if that weren't the case, a
single 3D vector would not be enough to define the plane of the circle.

I think the best solution for now is to make this change, and
investigate how the circle representation needs to be improved later.

[1] This would mean that circles and shapes based on circles can't
currently be rotated. There's no issue to track this, so if this is
true, one should be opened. I've added investigating this to my task
list.

The 3D definition is kind of wrong. I think all code currently assumes
that circles are in the x-y place[1]. Even if that weren't the case, a
single 3D vector would not be enough to define the plane of the circle.

I think the best solution for now is to make this change, and
investigate how the circle representation needs to be improved later.

[1] This would mean that circles and shapes based on circles can't
    currently be rotated. There's no issue to track this, so if this is
    true, one should be opened. I've added investigating this to my task
    list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant