Add math::Transform
#196
Merged
Add math::Transform
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces duplication in the method definitions, and opens the way for more refactorings.
This isn't an advantage in itself, but provides more flexibility for further refactorings of the math module.
The old name didn't really fit any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new struct to
crate::kernel::math,Transform, which wraps the transform type we've previously been using. It will make further changes to the transform code easier, and is thus relevant for #101.Depending on how my further experimentation with #193 goes, a full struct might turn out not to be necessary. This isn't much of a problem, as
Transformcan be converted back into a type definition quite easily, without changes required to the code using it.