Prevent make clean from failing when the file to remove does not exist #8

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

Well, I never realized I would change something here but with my maintainer hat on I can fully say I don't want my package to fail building on make clean.

Could you make a release with this change so I can package that for Debian/Ubuntu?

Or hell, even scratch this and just make a release. just realized the tarball has old Makefile.

Owner

hanschen commented Aug 13, 2015

I'll try to make a new release as soon as I can, probably tomorrow if I can find the time. Thanks for the heads up and for packaging ksuperkey!

Contributor

Mehanik commented Aug 13, 2015

Also you can use my repository for Ubuntu: https://launchpad.net/~mehanik/+archive/ubuntu/ksuperkey

Owner

hanschen commented Aug 14, 2015

I've made a new release over at KDE-apps: http://kde-apps.org/content/show.php/ksuperkey?content=154569

Just to make sure I understood your comment correctly, the -f flag is not necessary (i.e., I can close this pull request), correct?

Yeah sure, the existence test seems like an overkill here since you can just rm -f the file and it will not exit with an error when the file does not exist. But don't fix what's not broken :)

@Quintasan Quintasan closed this Aug 15, 2015

Owner

hanschen commented Aug 15, 2015

Thanks for confirming, please let me know if there are any other packaging issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment