New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude files generated by Intel Fortran during compilation #56

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@daloic

daloic commented Sep 22, 2018

Intel Fortran is generating __genmod.f90 for each Fortran module during compilation. This quick test prevents loading them. Maybe you should have in the .fortls file a default exclude pattern on the file name with the option to change it.

@michaelkonecny

This comment has been minimized.

Contributor

michaelkonecny commented Sep 22, 2018

These files get generated in the intermediate folder, which typically people would include in their .gitignore file.

I don't think it's a good solution to hardcode exclusion of files with a certain name pattern. In the long-term, this is potentially going to create debugging nightmares.

For now, I think people should just add their intermediate folder in excl_paths in the .fortls file.

In the long-term, it might be nice to have an option to "exclude files in .gitignore", which would be on by default, and could be disabled in .fortls.

@daloic

This comment has been minimized.

daloic commented Sep 22, 2018

The problem is only that you will have somebody asking for the support of Suversion, then Mercurial and others. If you support Git, there are no reasons not to support another VCS. A simple extra file pattern exclusion is probably simpler and it could be predefined to keep the out of the box experience as simple as possible.

@hansec

This comment has been minimized.

Owner

hansec commented Sep 28, 2018

@daloic thanks for the report. I don't use Visual Studio and it looks like there are lots of interesting things it does that you don't see on other platforms. In this case I think the best solution is to use the .fortls file to exclude the intermediate build directory @michaelkonecny described. I will look into allowing wildcard patterns for exclusion of files, but I don't think hardcoding is a good solution.

@hansec hansec closed this Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment