/rustler

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nif dirty func flags #29

Merged
merged 1 commit into from Nov 13, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dovahcrow @hansihe
@dovahcrow
Contributor

dovahcrow commented Nov 7, 2016

Fix #28
@hansihe

This comment has been minimized.

Show comment
Hide comment
@hansihe

hansihe Nov 9, 2016

Owner

This looks good.

It would be nice if the ErlNifTaskFlags enum could be reexported by some other module, probably the root rustler module. Normally the user should neither import nor use the wrapper module directly.
Owner

hansihe commented Nov 9, 2016

This looks good.

It would be nice if the ErlNifTaskFlags enum could be reexported by some other module, probably the root rustler module. Normally the user should neither import nor use the wrapper module directly.
@dovahcrow
add nif dirty func flags
Loading status checks…
5ae23ce
@dovahcrow

This comment has been minimized.

Show comment
Hide comment
@dovahcrow

dovahcrow Nov 13, 2016

Contributor

@hansihe re-exported the flag in root module.

P.S. We are using this feature in production now.
Contributor

dovahcrow commented Nov 13, 2016

@hansihe re-exported the flag in root module.

P.S. We are using this feature in production now.

@hansihe hansihe merged commit 8dea2fe into hansihe:master Nov 13, 2016
0 of 2 checks passed

0 of 2 checks passed

ci/circleci No test commands were found
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@hansihe

This comment has been minimized.

Show comment
Hide comment
@hansihe

hansihe Nov 13, 2016

Owner

Thanks for the contribution
Owner

hansihe commented Nov 13, 2016

Thanks for the contribution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment