New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serious bug in re-sort algorithm. #101

Merged
merged 1 commit into from Dec 7, 2018

Conversation

Projects
None yet
2 participants
@likejazz
Copy link
Contributor

likejazz commented Dec 7, 2018

It treats a byte as a string by default. So, if you sort 1, 5, 10, it will return the wrong result as 1, 10, 5 instead of 1, 5, 10. Therefore, It's necessary to explicitly convert byte to int.

Fix serious bug in re-sort algorithm.
It treats a byte as a string by default. So, if you sort `1, 5, 10`, it will return the wrong result as `1, 10, 5` instead of `1, 5, 10`. Therefore, It's necessary to explicitly convert byte to int.
@hanxiao

This comment has been minimized.

Copy link
Owner

hanxiao commented Dec 7, 2018

😱 that's serious for sure. thanks a million

@hanxiao hanxiao merged commit aba292b into hanxiao:master Dec 7, 2018

@likejazz likejazz deleted the likejazz:patch-1 branch Dec 7, 2018

@hanxiao

This comment has been minimized.

Copy link
Owner

hanxiao commented Dec 7, 2018

fyi it's now available on pypi 1.4.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment