Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial suggestions from Benjamin Kaduk's IESG review #25

Merged
merged 1 commit into from May 5, 2021

Conversation

kaduk
Copy link
Contributor

@kaduk kaduk commented May 4, 2021

I took a bit more license with some of these editorial suggestions than I typically would for this sort of thing; please push back on anything that looks funny (or worse).

@saradickinson
Copy link
Collaborator

@saradickinson saradickinson commented May 5, 2021

Thanks for these updates - they all improve the document!
And thanks for catching the missing 'not' in "number of configured secondaries but that do wish to support DoT for regular"

@saradickinson saradickinson merged commit 0b11dcf into hanzhang0116:master May 5, 2021
@kaduk
Copy link
Contributor Author

@kaduk kaduk commented May 6, 2021

And thanks for catching the missing 'not' in "number of configured secondaries but that do wish to support DoT for regular"

Happy to help! I confess that I did not even notice there was an omission the first time I read it; and only when I went back to edit something else did I spot the missing word. It seems it's the inverse of the common situation where

this is some text that is here to show that the
the words doubled across the line break are
easy to miss.

and humans just naturally fix things up in our subconscious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants