Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid multi-term for ElasticSearch #1717

Merged
merged 3 commits into from Feb 18, 2020

Conversation

jamesagnew
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #1717 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1717      +/-   ##
============================================
+ Coverage     79.52%   79.52%   +<.01%     
- Complexity    13532    13540       +8     
============================================
  Files           945      945              
  Lines         51411    51416       +5     
  Branches       8309     8310       +1     
============================================
+ Hits          40883    40891       +8     
  Misses         7343     7343              
+ Partials       3185     3182       -3
Impacted Files Coverage Δ Complexity Δ
...java/ca/uhn/fhir/jpa/term/BaseTermReadSvcImpl.java 89.68% <100%> (+0.03%) 284 <0> (+1) ⬆️
...hn/fhir/jpa/model/entity/ResourceHistoryTable.java 91.11% <0%> (-3.01%) 25% <0%> (+6%)
.../uhn/fhir/jpa/provider/r4/JpaSystemProviderR4.java 85.71% <0%> (ø) 11% <0%> (ø) ⬇️
...fhir/jpa/dao/expunge/ExpungeEverythingService.java 100% <0%> (ø) 13% <0%> (ø) ⬇️
.../ca/uhn/fhir/jpa/model/entity/BaseHasResource.java 100% <0%> (ø) 21% <0%> (-5%) ⬇️
...c/main/java/ca/uhn/fhir/jpa/dao/SearchBuilder.java 86.71% <0%> (+0.05%) 113% <0%> (ø) ⬇️
...va/ca/uhn/fhir/jpa/model/entity/ResourceTable.java 91.84% <0%> (+0.37%) 93% <0%> (+5%) ⬆️
...uhn/fhir/context/BaseRuntimeElementDefinition.java 87% <0%> (+1%) 36% <0%> (+1%) ⬆️
...ava/ca/uhn/fhir/jpa/model/entity/ResourceLink.java 92.64% <0%> (+1.21%) 19% <0%> (-1%) ⬇️
...uhn/fhir/rest/server/method/ReadMethodBinding.java 92.4% <0%> (+2.53%) 33% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60f16dd...856b6f3. Read the comment docs.

Copy link
Contributor

@jkiddo jkiddo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jamesagnew jamesagnew merged commit ab8dfa5 into master Feb 18, 2020
@jamesagnew jamesagnew deleted the ja_20200218_avoid_multiterm_for_es branch February 18, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants