Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure partition #2735

Open
fil512 opened this issue Jun 17, 2021 · 0 comments
Open

Measure partition #2735

fil512 opened this issue Jun 17, 2021 · 0 comments

Comments

@fil512
Copy link
Collaborator

fil512 commented Jun 17, 2021

When both cql and partitioning is enabled, when I run $evaluate-measure, it is producing an error “No interceptor provided a value for pointcut: STORAGE_PARTITION_IDENTIFY_READ”.
This seems fairly straightforward to fix. I’m familiar with Interceptors and Hooks with Pointcuts… So, I thought I would give a crack at implementing a solution.

I identified that the problem resides in MeasureOperationProvider.evaluateMeasure() on this line:
Measure measure = myMeasureDao.read(theId);

So, I added an @Autowired IInterceptorRegistry, created an @interceptor class, added a @hook for STORAGE_PARTITION_IDENTIFY_READ, and registered the interceptor in the interceptor registry prior to myMeasureDao.read() being called.
When the hook is triggered, both parameters RequestDetails and ServletRequestDetails were null. I don’t believe I can identify the partition ID without that having access to the request URL that includes the name of the partition.

So, suddenly, this issue became less “straight-forward” than I anticipated. But, I’m still hopeful I could produce a PR in a reasonable timeframe given a little guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant