Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add displayLanguage to the ValueSet/$expand #3619

Merged

Conversation

gjergjsheldija
Copy link
Contributor

this PR should enable something like :

curl --location --request GET 'http://localhost:8080/fhir/ValueSet/$expand?url=http://terminology.hl7.org/CodeSystem/emdn/vs&filter=text&count=100&displayLanguage=en-IT'

on a ValueSet with designations

Copy link
Collaborator

@jamesagnew jamesagnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, merging now. Thanks for the contrbution!

@jamesagnew jamesagnew merged commit 4684dde into hapifhir:master Jul 12, 2022
jamesagnew added a commit that referenced this pull request Jul 12, 2022
Qingyixia pushed a commit that referenced this pull request Jul 22, 2022
* add `displayLanguage` to the `ValueSet/$expand`

* fix tests

* fix tests
Qingyixia pushed a commit that referenced this pull request Jul 22, 2022
@toropok
Copy link

toropok commented Oct 24, 2022

@gjergjsheldija excuse me, is that PR works? cant figure out how to get languare designation with $expand operation

@gjergjsheldija
Copy link
Contributor Author

@toropok it should :)

does your code system have a displayLanguage ? is the expansion successful? please check the meta entry for this
are you using the correct version ?

@toropok
Copy link

toropok commented Oct 25, 2022

@toropok it should :)

does your code system have a displayLanguage ? is the expansion successful? please check the meta entry for this are you using the correct version ?

@gjergjsheldija well, I was trying with this ValueSet: https://hapi.fhir.org/baseR4/ValueSet/$expand?url=http://hl7.org/fhir/ValueSet/languages&displayLanguage=nl

Does displayLanguage have to be in CodeSystem concept only? is there any docs or posts somewhere "how to bake ValueSets right"?

@gjergjsheldija
Copy link
Contributor Author

hi @toropok
sorry for the late reply.
The parameters is used when the ValueSet is expanded. So it's not used in the query. Please check displayLanguage here http://hl7.org/fhir/valueset-operation-expand.html

best
Gjergj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants