Skip to content

Refactor SearchParamWithInlineReferencesExtractor to create a interface and a base class #4618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
StevenXLi opened this issue Mar 3, 2023 · 0 comments · Fixed by #4619
Closed

Refactor SearchParamWithInlineReferencesExtractor to create a interface and a base class #4618

StevenXLi opened this issue Mar 3, 2023 · 0 comments · Fixed by #4619

Comments

@StevenXLi
Copy link
Contributor

Describe the issue
In order to have parity of implementation on inline reference extractor, a refactor is required. A new interface is needed for SearchParamWithInlineReferencesExtractor, and the logic in extractInlineReferences() needs to live in a base implementation of that interface. This way any other implementation that uses a different IResourcePersistentId can have the same logic for the inline reference extractor.

Environment (please complete the following information):

  • HAPI FHIR Version: 6.5.0
  • OS: MacOS
  • Browser: chrome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@StevenXLi