New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve weakness in history operation #2642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Minor complaints in the tests.
hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/JpaHistoryR4Test.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/JpaHistoryR4Test.java
Show resolved
Hide resolved
| assertEquals(0, myCaptureQueriesListener.countDeleteQueries()); | ||
| assertEquals(0, myCaptureQueriesListener.countInsertQueries()); | ||
| assertEquals(0, myCaptureQueriesListener.countUpdateQueries()); | ||
| assertEquals(2, myCaptureQueriesListener.countSelectQueries()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. Some day it will change, and someone-not-you might have to figure out why 2 is now 3.
hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/JpaHistoryR4Test.java
Show resolved
Hide resolved
hapi-fhir-jpaserver-api/src/main/java/ca/uhn/fhir/jpa/api/config/DaoConfig.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/search/PersistedJpaBundleProvider.java
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/JpaHistoryR4Test.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2642 +/- ##
============================================
+ Coverage 82.47% 82.49% +0.01%
- Complexity 18862 18879 +17
============================================
Files 1273 1274 +1
Lines 67767 67814 +47
Branches 10352 10360 +8
============================================
+ Hits 55894 55940 +46
+ Misses 7875 7874 -1
- Partials 3998 4000 +2
Continue to review full report at Codecov.
|
Fix #2641