Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve weakness in history operation #2642

Merged
merged 9 commits into from May 7, 2021
Merged

Conversation

jamesagnew
Copy link
Collaborator

Fix #2641

Copy link
Contributor

@michaelabuckley michaelabuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Minor complaints in the tests.

assertEquals(0, myCaptureQueriesListener.countDeleteQueries());
assertEquals(0, myCaptureQueriesListener.countInsertQueries());
assertEquals(0, myCaptureQueriesListener.countUpdateQueries());
assertEquals(2, myCaptureQueriesListener.countSelectQueries());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Some day it will change, and someone-not-you might have to figure out why 2 is now 3.

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #2642 (fb0e229) into master (64564d5) will increase coverage by 0.01%.
The diff coverage is 94.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2642      +/-   ##
============================================
+ Coverage     82.47%   82.49%   +0.01%     
- Complexity    18862    18879      +17     
============================================
  Files          1273     1274       +1     
  Lines         67767    67814      +47     
  Branches      10352    10360       +8     
============================================
+ Hits          55894    55940      +46     
+ Misses         7875     7874       -1     
- Partials       3998     4000       +2     
Impacted Files Coverage Δ Complexity Δ
.../java/ca/uhn/fhir/jpa/util/MemoryCacheService.java 87.67% <86.20%> (-3.24%) 10.00 <0.00> (ø)
...ain/java/ca/uhn/fhir/jpa/api/config/DaoConfig.java 92.56% <100.00%> (+0.15%) 126.00 <7.00> (+2.00)
...a/uhn/fhir/jpa/api/model/HistoryCountModeEnum.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...hn/fhir/jpa/search/PersistedJpaBundleProvider.java 90.78% <100.00%> (+2.68%) 50.00 <10.00> (+10.00)
.../jpa/util/CircularQueueCaptureQueriesListener.java 93.33% <100.00%> (+0.20%) 48.00 <5.00> (+3.00)
.../main/java/ca/uhn/fhir/jpa/dao/HistoryBuilder.java 100.00% <0.00%> (+1.51%) 20.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64564d5...fb0e229. Read the comment docs.

@jamesagnew jamesagnew merged commit 5a9f499 into master May 7, 2021
9 checks passed
@jamesagnew jamesagnew deleted the ja_20210505_history_dos branch May 7, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential Denial of Service in JPA Server via history operation
2 participants