Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check on code lookup result. #2674

Merged
merged 4 commits into from May 25, 2021

Conversation

IanMMarshall
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #2674 (a878ef2) into master (2badae2) will increase coverage by 0.00%.
The diff coverage is 87.64%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2674   +/-   ##
=========================================
  Coverage     82.50%   82.51%           
- Complexity    18944    18959   +15     
=========================================
  Files          1274     1274           
  Lines         68014    68039   +25     
  Branches      10393    10401    +8     
=========================================
+ Hits          56118    56142   +24     
  Misses         7882     7882           
- Partials       4014     4015    +1     
Impacted Files Coverage Δ
...a/ca/uhn/fhir/jpa/dao/expunge/PartitionRunner.java 68.96% <ø> (ø)
...tion/match/registry/SubscriptionCanonicalizer.java 74.43% <42.85%> (-1.36%) ⬇️
...ava/ca/uhn/fhir/jpa/dao/index/IdHelperService.java 82.27% <80.00%> (+0.08%) ⬆️
...validator/VersionSpecificWorkerContextWrapper.java 61.94% <81.81%> (ø)
.../java/ca/uhn/fhir/jpa/util/MemoryCacheService.java 86.04% <85.71%> (-0.03%) ⬇️
...rc/main/java/ca/uhn/fhir/context/ModelScanner.java 82.35% <100.00%> (+0.13%) ⬆️
...uhn/fhir/jpa/dao/expunge/DeleteExpungeService.java 86.66% <100.00%> (+1.33%) ⬆️
.../uhn/fhir/jpa/search/SearchCoordinatorSvcImpl.java 92.57% <100.00%> (+0.02%) ⬆️
.../ca/uhn/fhir/jpa/search/builder/SearchBuilder.java 85.56% <100.00%> (+0.19%) ⬆️
...a/uhn/fhir/jpa/searchparam/SearchParameterMap.java 88.74% <100.00%> (+0.07%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c722e6...a878ef2. Read the comment docs.

Copy link
Collaborator

@fil512 fil512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@IanMMarshall IanMMarshall merged commit 5c6ef2e into master May 25, 2021
@IanMMarshall IanMMarshall deleted the 2673-fix-npe-on-populate-display-interceptor branch May 25, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResponseTerminologyDisplayPopulationInterceptor throws NPE when code lookup returns null
3 participants