Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added null checks #2747

Merged
merged 3 commits into from Jun 23, 2021
Merged

Added null checks #2747

merged 3 commits into from Jun 23, 2021

Conversation

nvg-smile
Copy link
Collaborator

Closes #2746

Copy link
Collaborator

@tadgh tadgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a changelog, and a minor change requested to parameter naming. Otherwise, approved.

@lgtm-com
Copy link

lgtm-com bot commented Jun 22, 2021

This pull request introduces 3 alerts when merging 9caa5e6 into 912b44c - view on LGTM.com

new alerts:

  • 2 for Unused format argument
  • 1 for Useless null check

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #2747 (9caa5e6) into master (912b44c) will decrease coverage by 0.01%.
The diff coverage is 12.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2747      +/-   ##
============================================
- Coverage     82.57%   82.55%   -0.02%     
- Complexity    19328    19329       +1     
============================================
  Files          1296     1296              
  Lines         69152    69177      +25     
  Branches      10589    10599      +10     
============================================
+ Hits          57101    57109       +8     
- Misses         7971     7986      +15     
- Partials       4080     4082       +2     
Impacted Files Coverage Δ
...hir/jpa/mdm/interceptor/MdmStorageInterceptor.java 20.25% <12.00%> (-2.17%) ⬇️
...ain/java/ca/uhn/fhir/mdm/util/MdmResourceUtil.java 66.66% <16.66%> (-11.60%) ⬇️
...n/fhir/jpa/config/HapiFhirHibernateJpaDialect.java 90.62% <0.00%> (+15.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 912b44c...9caa5e6. Read the comment docs.

@nvg-smile nvg-smile changed the title WIP: Added null checks Added null checks Jun 23, 2021
@nvg-smile nvg-smile merged commit 6feaa12 into master Jun 23, 2021
@nvg-smile nvg-smile deleted the 2746_npe_in_mdm_utils branch June 23, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE in MDM utils
2 participants