Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forced offset search JPA interceptor #2756

Merged
merged 9 commits into from Jun 25, 2021

Conversation

jamesagnew
Copy link
Collaborator

Add an interceptor to the JPA server that forces all searches to be offset searches instead of ever relying on the query cache.

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #2756 (faa8ef7) into master (8a2ad8d) will decrease coverage by 0.00%.
The diff coverage is 74.68%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2756      +/-   ##
============================================
- Coverage     82.54%   82.54%   -0.01%     
- Complexity    19339    19368      +29     
============================================
  Files          1296     1297       +1     
  Lines         69198    69261      +63     
  Branches      10610    10619       +9     
============================================
+ Hits          57122    57170      +48     
- Misses         7989     8001      +12     
- Partials       4087     4090       +3     
Impacted Files Coverage Δ
...a/uhn/fhir/jpa/searchparam/SearchParameterMap.java 88.81% <0.00%> (-0.29%) ⬇️
.../interceptor/ForceOffsetSearchModeInterceptor.java 50.00% <50.00%> (ø)
...a/ca/uhn/fhir/rest/api/server/IBundleProvider.java 94.73% <50.00%> (+6.50%) ⬆️
.../jpa/util/CircularQueueCaptureQueriesListener.java 95.23% <60.00%> (-2.58%) ⬇️
...e/src/main/java/ca/uhn/fhir/jpa/entity/Search.java 95.53% <66.66%> (-0.87%) ⬇️
...ver/method/BaseResourceReturningMethodBinding.java 86.42% <72.72%> (-2.68%) ⬇️
.../jpa/util/CurrentThreadCaptureQueriesListener.java 50.00% <75.00%> (+9.09%) ⬆️
.../uhn/fhir/jpa/search/SearchCoordinatorSvcImpl.java 92.66% <100.00%> (+0.40%) ⬆️
.../uhn/fhir/jpa/util/BaseCaptureQueriesListener.java 97.56% <100.00%> (+0.78%) ⬆️
.../ca/uhn/fhir/rest/server/SimpleBundleProvider.java 80.00% <100.00%> (+4.13%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a2ad8d...faa8ef7. Read the comment docs.

@jamesagnew jamesagnew merged commit 7185089 into master Jun 25, 2021
@jamesagnew jamesagnew deleted the ja_20210622_jpa_offset_searches branch June 25, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant