Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix false rule matches #2762

Merged
merged 7 commits into from
Jun 27, 2021
Merged

fix false rule matches #2762

merged 7 commits into from
Jun 27, 2021

Conversation

fil512
Copy link
Collaborator

@fil512 fil512 commented Jun 27, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jun 27, 2021

Codecov Report

Merging #2762 (0ae741e) into master (5565bf9) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2762   +/-   ##
=========================================
  Coverage     82.54%   82.54%           
- Complexity    19371    19379    +8     
=========================================
  Files          1297     1297           
  Lines         69286    69288    +2     
  Branches      10623    10624    +1     
=========================================
+ Hits          57189    57195    +6     
+ Misses         8004     8000    -4     
  Partials       4093     4093           
Impacted Files Coverage Δ
.../fhir/rest/server/interceptor/auth/RuleImplOp.java 81.35% <50.00%> (+0.46%) ⬆️
...fhir/rest/server/interceptor/auth/RuleBuilder.java 96.79% <100.00%> (ø)
.../java/ca/uhn/fhir/jpa/util/MemoryCacheService.java 82.10% <0.00%> (-2.11%) ⬇️
...ava/ca/uhn/fhir/jpa/dao/index/IdHelperService.java 81.27% <0.00%> (-0.86%) ⬇️
...ca/uhn/fhir/jpa/dao/tx/HapiTransactionService.java 74.57% <0.00%> (+3.38%) ⬆️
...n/fhir/jpa/config/HapiFhirHibernateJpaDialect.java 90.62% <0.00%> (+15.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5565bf9...0ae741e. Read the comment docs.

Copy link
Collaborator

@lmds lmds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@fil512 fil512 merged commit 9500a1a into master Jun 27, 2021
@fil512 fil512 deleted the ks-20210626-fix-false-rule-matches branch June 27, 2021 14:34
tadgh pushed a commit that referenced this pull request Jul 6, 2021
* fixed an issue with matching compartments to lists of ids

* change log

* Added extra guards against false rule matches.

* changelog

* fix inCompartment

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants