Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed mdm rules #2764

Merged
merged 4 commits into from
Jun 29, 2021
Merged

fixed mdm rules #2764

merged 4 commits into from
Jun 29, 2021

Conversation

fil512
Copy link
Collaborator

@fil512 fil512 commented Jun 28, 2021

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Jun 28, 2021

This pull request fixes 1 alert when merging 074c524 into 9500a1a - view on LGTM.com

fixed alerts:

  • 1 for Dereferenced variable may be null

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #2764 (a8283d7) into master (9500a1a) will decrease coverage by 0.00%.
The diff coverage is 83.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2764      +/-   ##
============================================
- Coverage     82.54%   82.54%   -0.01%     
- Complexity    19378    19389      +11     
============================================
  Files          1297     1298       +1     
  Lines         69288    69308      +20     
  Branches      10624    10623       -1     
============================================
+ Hits          57197    57210      +13     
- Misses         7998     8005       +7     
  Partials       4093     4093              
Impacted Files Coverage Δ
...der/ReverseCronologicalBatchResourcePidReader.java 86.20% <ø> (ø)
...ca/uhn/fhir/jpa/dao/tx/HapiTransactionService.java 74.57% <ø> (+3.38%) ⬆️
.../fhir/rest/server/interceptor/auth/RuleImplOp.java 81.60% <81.81%> (+0.24%) ⬆️
.../fhir/rest/server/interceptor/auth/RuleTarget.java 100.00% <100.00%> (ø)
...n/fhir/jpa/config/HapiFhirHibernateJpaDialect.java 75.00% <0.00%> (-15.63%) ⬇️
.../java/ca/uhn/fhir/jpa/util/MemoryCacheService.java 82.10% <0.00%> (-2.11%) ⬇️
...ava/ca/uhn/fhir/jpa/dao/index/IdHelperService.java 81.27% <0.00%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9500a1a...a8283d7. Read the comment docs.

Copy link
Collaborator

@tadgh tadgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice refactor. That class was getting hairy.

@lgtm-com
Copy link

lgtm-com bot commented Jun 29, 2021

This pull request fixes 1 alert when merging a8283d7 into 9500a1a - view on LGTM.com

fixed alerts:

  • 1 for Dereferenced variable may be null

@fil512 fil512 merged commit 795fb31 into master Jun 29, 2021
@fil512 fil512 deleted the ks-20210628-mdm-prefix-compartments branch June 29, 2021 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants