Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paging implementation for MDM query links operation #2767

Merged
merged 17 commits into from
Jul 2, 2021
Merged

Conversation

tadgh
Copy link
Collaborator

@tadgh tadgh commented Jun 29, 2021

Closes #2765
Add the following query parameters to both $mdm-query-links and $mdm-duplicate-golden-resources:

  • _offset
  • _count

This allows for rudimentary pagination on those two operations. The response generates next self and prev links in the resulting Parameters response, which point to the next page of results. While the client could keep track of its last offset, we elect to also provide it back as part of the response.

Copy link
Contributor

@michaelabuckley michaelabuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #2767 (cfcc939) into master (795fb31) will decrease coverage by 0.00%.
The diff coverage is 89.24%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2767      +/-   ##
============================================
- Coverage     82.55%   82.54%   -0.01%     
- Complexity    19389    19416      +27     
============================================
  Files          1298     1301       +3     
  Lines         69308    69384      +76     
  Branches      10623    10636      +13     
============================================
+ Hits          57214    57276      +62     
- Misses         8001     8013      +12     
- Partials       4093     4095       +2     
Impacted Files Coverage Δ
...src/main/java/ca/uhn/fhir/util/ParametersUtil.java 95.35% <ø> (ø)
...hir/jpa/search/builder/sql/SearchQueryBuilder.java 92.74% <ø> (ø)
...va/ca/uhn/fhir/mdm/provider/MdmProviderLoader.java 30.00% <ø> (ø)
.../fhir/rest/server/interceptor/auth/RuleTarget.java 100.00% <ø> (ø)
...ava/ca/uhn/fhir/mdm/api/paging/MdmPageRequest.java 65.38% <65.38%> (ø)
...ca/uhn/fhir/mdm/api/paging/MdmPageLinkBuilder.java 94.73% <94.73%> (ø)
...in/java/ca/uhn/fhir/jpa/mdm/dao/MdmLinkDaoSvc.java 85.32% <100.00%> (ø)
.../ca/uhn/fhir/jpa/mdm/svc/MdmControllerSvcImpl.java 100.00% <100.00%> (ø)
...a/ca/uhn/fhir/jpa/mdm/svc/MdmLinkQuerySvcImpl.java 100.00% <100.00%> (ø)
...a/ca/uhn/fhir/mdm/api/paging/MdmPageLinkTuple.java 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 795fb31...cfcc939. Read the comment docs.

@tadgh tadgh merged commit a4fb729 into master Jul 2, 2021
@tadgh tadgh deleted the 2765-mdm-paging branch July 2, 2021 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add paging support to EMPI operations
3 participants