Skip to content

Conversation

@frankjtao
Copy link
Collaborator

No description provided.

@frankjtao frankjtao self-assigned this Jul 16, 2021
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #2800 (4e318f1) into master (0235296) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2800      +/-   ##
============================================
+ Coverage     82.58%   82.60%   +0.02%     
- Complexity    19516    19526      +10     
============================================
  Files          1305     1306       +1     
  Lines         69611    69632      +21     
  Branches      10678    10681       +3     
============================================
+ Hits          57485    57517      +32     
+ Misses         8024     8013      -11     
  Partials       4102     4102              
Impacted Files Coverage Δ
...n/java/ca/uhn/fhir/jpa/term/TermLoaderSvcImpl.java 91.29% <100.00%> (+0.06%) ⬆️
.../fhir/jpa/term/loinc/LoincConsumerNameHandler.java 100.00% <100.00%> (ø)
...fhir/jpa/term/loinc/LoincUploadPropertiesEnum.java 89.83% <100.00%> (+0.35%) ⬆️
.../uhn/fhir/jpa/search/SearchCoordinatorSvcImpl.java 93.17% <0.00%> (+0.51%) ⬆️
...or/TransactionConcurrencySemaphoreInterceptor.java 85.29% <0.00%> (+1.47%) ⬆️
...ca/uhn/fhir/jpa/dao/tx/HapiTransactionService.java 75.00% <0.00%> (+3.12%) ⬆️
...n/fhir/jpa/config/HapiFhirHibernateJpaDialect.java 90.62% <0.00%> (+15.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0235296...4e318f1. Read the comment docs.

@jamesagnew
Copy link
Collaborator

Hi @frankjtao - This looks good. One request, can you add a changelog before we merge?

@frankjtao
Copy link
Collaborator Author

frankjtao commented Jul 16, 2021

Hi @frankjtao - This looks good. One request, can you add a changelog before we merge?
@jamesagnew I will add changelog after LinguisticVariants is added.

@frankjtao frankjtao closed this Jul 16, 2021
@jamesagnew
Copy link
Collaborator

@frankjtao ah ok - do you not want this merged then? Just confirming, since it has been closed without a merge.

@frankjtao frankjtao reopened this Jul 16, 2021
@frankjtao
Copy link
Collaborator Author

@frankjtao ah ok - do you not want this merged then? Just confirming, since it has been closed without a merge.

@jamesagnew Sorry, clicked the wrong button. Will do the merge after LinguisticVariants is implemented.

@frankjtao
Copy link
Collaborator Author

@frankjtao ah ok - do you not want this merged then? Just confirming, since it has been closed without a merge.

@jamesagnew Sorry, clicked the wrong button. Will do the merge after LinguisticVariants is implemented.

@jamesagnew I have changed mind, will merge this PR.

@frankjtao frankjtao merged commit 946080d into master Jul 16, 2021
@frankjtao frankjtao deleted the ft_20210715_add_lonic_consumername_lang branch July 16, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants