Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patient ID Partition Mode should support conditional create #2828

Merged
merged 10 commits into from
Jul 26, 2021

Conversation

jamesagnew
Copy link
Collaborator

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Jul 23, 2021

This pull request introduces 1 alert when merging 1c35276 into 6f7f787 - view on LGTM.com

new alerts:

  • 1 for Spurious Javadoc @param tags

@lgtm-com
Copy link

lgtm-com bot commented Jul 23, 2021

This pull request introduces 1 alert when merging b29163b into 6f7f787 - view on LGTM.com

new alerts:

  • 1 for Spurious Javadoc @param tags

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #2828 (51ed080) into master (2539f49) will increase coverage by 0.02%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2828      +/-   ##
============================================
+ Coverage     82.56%   82.58%   +0.02%     
- Complexity    19592    19609      +17     
============================================
  Files          1311     1311              
  Lines         69869    69887      +18     
  Branches      10710    10714       +4     
============================================
+ Hits          57689    57718      +29     
+ Misses         8075     8064      -11     
  Partials       4105     4105              
Impacted Files Coverage Δ
...jpa/dao/dstu3/FhirResourceDaoObservationDstu3.java 22.22% <0.00%> (ø)
.../fhir/jpa/dao/r5/FhirResourceDaoObservationR5.java 22.22% <0.00%> (ø)
.../uhn/fhir/jpa/dao/r5/FhirResourceDaoPatientR5.java 4.54% <0.00%> (ø)
...hn/fhir/jpa/model/search/SearchRuntimeDetails.java 91.66% <ø> (ø)
...java/ca/uhn/fhir/jpa/api/dao/IFhirResourceDao.java 25.00% <33.33%> (+25.00%) ⬆️
...terceptor/model/ReadPartitionIdRequestDetails.java 71.42% <85.71%> (+3.00%) ⬆️
...fhir/jpa/bulk/export/job/ResourceToFileWriter.java 91.17% <100.00%> (ø)
...a/ca/uhn/fhir/jpa/dao/BaseHapiFhirResourceDao.java 92.39% <100.00%> (+0.17%) ⬆️
...ir/jpa/dao/BaseHapiFhirResourceDaoObservation.java 80.95% <100.00%> (ø)
.../uhn/fhir/jpa/dao/FhirResourceDaoPatientDstu2.java 92.59% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bbb403...51ed080. Read the comment docs.

@jamesagnew jamesagnew merged commit f957661 into master Jul 26, 2021
@jamesagnew jamesagnew deleted the ja_20210722_patient_id_partition_mode_fixes branch July 26, 2021 18:18
jamesagnew added a commit that referenced this pull request Jul 26, 2021
* Fixes

* Test fix

* Add changelog

* Test fixes

* Test fixes

* Docs tweak

* Partitioning fixes

* Import fix

* Fix test data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant