Skip to content

Flush SP cache after SP change #4566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2023
Merged

Flush SP cache after SP change #4566

merged 3 commits into from
Feb 28, 2023

Conversation

jamesagnew
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Base: 81.32% // Head: 81.42% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (bd007aa) compared to base (2f5ffe7).
Patch has no changes to coverable lines.

❗ Current head bd007aa differs from pull request most recent head d6bf12d. Consider uploading reports for the commit d6bf12d to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #4566      +/-   ##
============================================
+ Coverage     81.32%   81.42%   +0.09%     
- Complexity    23650    23825     +175     
============================================
  Files          1425     1432       +7     
  Lines         86399    87333     +934     
  Branches      11677    11787     +110     
============================================
+ Hits          70265    71108     +843     
- Misses        10947    10994      +47     
- Partials       5187     5231      +44
Impacted Files Coverage Δ
ca/uhn/fhir/mdm/api/MdmQuerySearchParameters.java 49.31% <0.00%> (-35.94%) ⬇️
org/hl7/fhir/r5/hapi/fhirpath/FhirPathR5.java 40.74% <0.00%> (-28.01%) ⬇️
...a/uhn/fhir/jpa/mdm/svc/MdmLinkQuerySvcImplSvc.java 41.66% <0.00%> (-25.00%) ⬇️
org/hl7/fhir/r4/hapi/fluentpath/FhirPathR4.java 62.96% <0.00%> (-24.54%) ⬇️
.../hl7/fhir/dstu3/hapi/fluentpath/FhirPathDstu3.java 76.00% <0.00%> (-17.75%) ⬇️
...pa/model/entity/NormalizedQuantitySearchLevel.java 83.33% <0.00%> (-16.67%) ⬇️
...ir/rest/server/messaging/json/BaseJsonMessage.java 76.92% <0.00%> (-13.99%) ⬇️
ca/uhn/fhir/jpa/mdm/svc/MdmControllerSvcImpl.java 63.44% <0.00%> (-9.40%) ⬇️
ca/uhn/fhir/jpa/batch2/JpaJobPersistenceImpl.java 85.62% <0.00%> (-5.66%) ⬇️
...r/narrative/CustomThymeleafNarrativeGenerator.java 94.73% <0.00%> (-5.27%) ⬇️
... and 150 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

michaelabuckley
michaelabuckley approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@michaelabuckley michaelabuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about cluster-cache

@jamesagnew jamesagnew merged commit 2083b7c into master Feb 28, 2023
@jamesagnew jamesagnew deleted the ja_20230218_flush_sp_cache_after_sp_change branch February 28, 2023 18:42
jamesagnew added a commit that referenced this pull request Mar 2, 2023
@jamesagnew
Revert "Flush SP cache after SP change (#4566)"
954e099 
This reverts commit 2083b7c.
@jamesagnew jamesagnew mentioned this pull request Mar 2, 2023
Merged
jamesagnew added a commit that referenced this pull request Mar 3, 2023
@jamesagnew
Revert "Flush SP cache after SP change (#4566)" (#4614)
9492999 
This reverts commit 2083b7c.
michaelabuckley pushed a commit that referenced this pull request Mar 3, 2023
@jamesagnew @michaelabuckley
Revert "Flush SP cache after SP change (#4566)" (#4614)
99e6040 
This reverts commit 2083b7c.
jamesagnew added a commit that referenced this pull request Mar 8, 2023
@jamesagnew
Revert "Revert "Flush SP cache after SP change (#4566)" (#4614)"
86bd155 
This reverts commit 9492999.
jamesagnew added a commit that referenced this pull request Mar 29, 2023
@jamesagnew
Re-enable "Flush SP cache after SP change" (#4635)
e69fe05 
* Revert "Revert "Flush SP cache after SP change (#4566)" (#4614)"

This reverts commit 9492999.

* Additions for performance

* HAPI version bump

* Test logging improvement

* Test fixes

* Test fix

* Test fix

* Compile fix

* Fix

* License headers

* Test fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelabuckley michaelabuckley michaelabuckley approved these changes

@TipzCM TipzCM TipzCM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesagnew @michaelabuckley @TipzCM