Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support retry of $reindex version conflict #4603

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Conversation

michaelabuckley
Copy link
Contributor

The change in #4584 might cause $reindex to throw a new kind of error. This adds support for retry for ObjectOptimisticLockingFailureException in addition to ResourceVersionConflictException and DataIntegrityViolationException.

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.17 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (e1a0cb1) 81.49%.

❗ Current head e1a0cb1 differs from pull request most recent head 3cc881a. Consider uploading reports for the commit 3cc881a to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4603      +/-   ##
============================================
+ Coverage     81.32%   81.49%   +0.17%     
- Complexity    23650    23990     +340     
============================================
  Files          1425     1442      +17     
  Lines         86399    87873    +1474     
  Branches      11677    11826     +149     
============================================
+ Hits          70265    71615    +1350     
- Misses        10947    11002      +55     
- Partials       5187     5256      +69     
Impacted Files Coverage Δ
ca/uhn/fhir/mdm/api/MdmQuerySearchParameters.java 49.31% <0.00%> (-35.94%) ⬇️
org/hl7/fhir/r5/hapi/fhirpath/FhirPathR5.java 40.74% <0.00%> (-28.01%) ⬇️
...a/uhn/fhir/jpa/mdm/svc/MdmLinkQuerySvcImplSvc.java 41.66% <0.00%> (-25.00%) ⬇️
org/hl7/fhir/r4/hapi/fluentpath/FhirPathR4.java 62.96% <0.00%> (-24.54%) ⬇️
.../hl7/fhir/dstu3/hapi/fluentpath/FhirPathDstu3.java 76.00% <0.00%> (-17.75%) ⬇️
...pa/model/entity/NormalizedQuantitySearchLevel.java 83.33% <0.00%> (-16.67%) ⬇️
...ir/rest/server/messaging/json/BaseJsonMessage.java 76.92% <0.00%> (-13.99%) ⬇️
ca/uhn/fhir/jpa/mdm/svc/MdmControllerSvcImpl.java 63.44% <0.00%> (-9.40%) ⬇️
ca/uhn/fhir/jpa/batch2/JpaJobPersistenceImpl.java 85.62% <0.00%> (-5.66%) ⬇️
...r/narrative/CustomThymeleafNarrativeGenerator.java 94.73% <0.00%> (-5.27%) ⬇️
... and 197 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…ex-retry

# Conflicts:
#	hapi-fhir-storage/src/main/java/ca/uhn/fhir/jpa/dao/tx/HapiTransactionService.java
@michaelabuckley michaelabuckley enabled auto-merge (squash) February 28, 2023 16:59
@michaelabuckley michaelabuckley merged commit ec13b75 into master Feb 28, 2023
@michaelabuckley michaelabuckley deleted the mb-reindex-retry branch February 28, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants