Skip to content

V2 index for string and URI #4629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 24, 2023
Merged

V2 index for string and URI #4629

merged 10 commits into from
Mar 24, 2023

Conversation

michaelabuckley
Copy link
Contributor

@michaelabuckley michaelabuckley commented Mar 7, 2023

Change string and URI indexes to handle exact match faster.
Change :above query on URI to use hash_identity instead of old sp_name query.

@michaelabuckley michaelabuckley changed the title V2 index for string and uri V2 index for string Mar 8, 2023
@michaelabuckley michaelabuckley enabled auto-merge (squash) March 8, 2023 22:09
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.16 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (93b10ff) 81.49%.

❗ Current head 93b10ff differs from pull request most recent head 204f7c1. Consider uploading reports for the commit 204f7c1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4629      +/-   ##
============================================
+ Coverage     81.32%   81.49%   +0.16%     
- Complexity    23650    24038     +388     
============================================
  Files          1425     1443      +18     
  Lines         86399    88027    +1628     
  Branches      11677    11841     +164     
============================================
+ Hits          70265    71736    +1471     
- Misses        10947    11042      +95     
- Partials       5187     5249      +62     

see 228 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@jmarchionatto jmarchionatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments

# Conflicts:
#	hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/migrate/tasks/HapiFhirJpaMigrationTasks.java
@michaelabuckley michaelabuckley changed the title V2 index for string V2 index for string and URI Mar 24, 2023
@patrick-vachon-smilecdr
Copy link
Contributor

Looks good to me!

@michaelabuckley michaelabuckley merged commit 7d26a7a into master Mar 24, 2023
@michaelabuckley michaelabuckley deleted the mb-uri-string-index branch March 24, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants