-
Notifications
You must be signed in to change notification settings - Fork 1.4k
V2 index for string and URI #4629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4629 +/- ##
============================================
+ Coverage 81.32% 81.49% +0.16%
- Complexity 23650 24038 +388
============================================
Files 1425 1443 +18
Lines 86399 88027 +1628
Branches 11677 11841 +164
============================================
+ Hits 70265 71736 +1471
- Misses 10947 11042 +95
- Partials 5187 5249 +62 see 228 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with comments
hapi-fhir-jpaserver-test-r4/src/test/resources/logback-test.xml
Outdated
Show resolved
Hide resolved
...r-test-r4/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoR4StandardQueriesNoFTTest.java
Show resolved
Hide resolved
# Conflicts: # hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/migrate/tasks/HapiFhirJpaMigrationTasks.java
Looks good to me! |
Change string and URI indexes to handle exact match faster.
Change :above query on URI to use hash_identity instead of old sp_name query.