Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search and Sort on Uplifted Refchains #4633

Merged
merged 35 commits into from
Mar 15, 2023
Merged

Conversation

jamesagnew
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.24 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (975b80f) 81.57%.

❗ Current head 975b80f differs from pull request most recent head b21de8d. Consider uploading reports for the commit b21de8d to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4633      +/-   ##
============================================
+ Coverage     81.32%   81.57%   +0.24%     
- Complexity    23650    24188     +538     
============================================
  Files          1425     1449      +24     
  Lines         86399    88464    +2065     
  Branches      11677    11911     +234     
============================================
+ Hits          70265    72162    +1897     
- Misses        10947    11037      +90     
- Partials       5187     5265      +78     

see 251 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@michaelabuckley michaelabuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat stuff. The javadoc was very helpful.

It would be nice to standarize on language between chained vs uplifted.

@jamesagnew jamesagnew merged commit cf5470a into master Mar 15, 2023
@jamesagnew jamesagnew deleted the ja_20230221_uplift_refchains branch March 15, 2023 11:04
@jkiddo
Copy link
Contributor

jkiddo commented Apr 25, 2023

@jamesagnew will Location.near also be a valid parameter to this _sort?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants