Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent Transaction Conditonal Creates #4639

Merged
merged 19 commits into from
Mar 14, 2023

Conversation

AD1306
Copy link
Collaborator

@AD1306 AD1306 commented Mar 9, 2023

Avoid a concurrency failure when executing transactions at high concurrency using conditional creates and placeholder references

@AD1306 AD1306 added the bug label Mar 9, 2023
@AD1306 AD1306 changed the title placeholder create transaction retry draft:placeholder create transaction retry Mar 9, 2023
@AD1306 AD1306 marked this pull request as draft March 9, 2023 20:44
@AD1306 AD1306 changed the title draft:placeholder create transaction retry placeholder create transaction retry Mar 9, 2023
@jamesagnew jamesagnew changed the title placeholder create transaction retry Concurrent Transaction Conditonal Creates Mar 14, 2023
@jamesagnew jamesagnew marked this pull request as ready for review March 14, 2023 10:21
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.18 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (d3a2cc4) 81.51%.

❗ Current head d3a2cc4 differs from pull request most recent head ca1756b. Consider uploading reports for the commit ca1756b to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4639      +/-   ##
============================================
+ Coverage     81.32%   81.51%   +0.18%     
- Complexity    23650    24085     +435     
============================================
  Files          1425     1448      +23     
  Lines         86399    88129    +1730     
  Branches      11677    11850     +173     
============================================
+ Hits          70265    71838    +1573     
- Misses        10947    11036      +89     
- Partials       5187     5255      +68     

see 241 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jamesagnew jamesagnew merged commit 8956b27 into master Mar 14, 2023
@jamesagnew jamesagnew deleted the ad-concurrent-transaction-inline-match branch March 14, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants