Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune postgres settings for Hapi indexing. #4712

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

michaelabuckley
Copy link
Contributor

Two tuning changes for PG:

  1. Lower the autovacuum threshold for all index tables. Postgres can't use a covering index to skip row-reads until the visibility map is updated. This happens during vacuum.
  2. Deepen the most-frequent stats collection for all hash columns. The PG default is only 100, and our hash columns index unique values for 100s of SPs. We need this so the planner has better cardinality estimates.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.19 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (083d54e) 81.52%.

❗ Current head 083d54e differs from pull request most recent head f28c7e7. Consider uploading reports for the commit f28c7e7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4712      +/-   ##
============================================
+ Coverage     81.32%   81.52%   +0.19%     
- Complexity    23650    24363     +713     
============================================
  Files          1425     1468      +43     
  Lines         86399    89069    +2670     
  Branches      11677    11992     +315     
============================================
+ Hits          70265    72614    +2349     
- Misses        10947    11162     +215     
- Partials       5187     5293     +106     

see 1417 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@patrick-vachon-smilecdr patrick-vachon-smilecdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done!

Copy link
Contributor

@patrick-vachon-smilecdr patrick-vachon-smilecdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@michaelabuckley michaelabuckley enabled auto-merge (squash) April 5, 2023 16:27
@michaelabuckley michaelabuckley merged commit f1166fe into master Apr 5, 2023
@michaelabuckley michaelabuckley deleted the mb-postgress-tuning branch April 5, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants