Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4B SubscriptionTopic support #4724

Merged
merged 39 commits into from
Apr 12, 2023
Merged

R4B SubscriptionTopic support #4724

merged 39 commits into from
Apr 12, 2023

Conversation

fil512
Copy link
Collaborator

@fil512 fil512 commented Apr 8, 2023

Ready for review

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.26 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (f7cf15b) 81.59%.

❗ Current head f7cf15b differs from pull request most recent head 8b9944c. Consider uploading reports for the commit 8b9944c to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4724      +/-   ##
============================================
+ Coverage     81.32%   81.59%   +0.26%     
- Complexity    23650    24539     +889     
============================================
  Files          1425     1482      +57     
  Lines         86399    89759    +3360     
  Branches      11677    12072     +395     
============================================
+ Hits          70265    73235    +2970     
- Misses        10947    11197     +250     
- Partials       5187     5327     +140     

see 1431 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@epeartree epeartree self-requested a review April 11, 2023 13:58
Copy link
Collaborator

@epeartree epeartree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code!

@fil512 fil512 enabled auto-merge (squash) April 12, 2023 00:00
@fil512 fil512 merged commit b88ccbc into master Apr 12, 2023
@fil512 fil512 deleted the ks-20230407-r4b-subs branch April 12, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants