Skip to content

Improve Subscription Retriggering Efficiency #4742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 17, 2023

Conversation

jamesagnew
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@tadgh tadgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Just checking: does this compile against CDR?

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.12 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (c2a6458) 81.45%.

❗ Current head c2a6458 differs from pull request most recent head 480ad54. Consider uploading reports for the commit 480ad54 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4742      +/-   ##
============================================
+ Coverage     81.32%   81.45%   +0.12%     
- Complexity    23650    24844    +1194     
============================================
  Files          1425     1516      +91     
  Lines         86399    91103    +4704     
  Branches      11677    12238     +561     
============================================
+ Hits          70265    74208    +3943     
- Misses        10947    11484     +537     
- Partials       5187     5411     +224     

see 1465 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jamesagnew jamesagnew merged commit 7bdbda9 into master Apr 17, 2023
@jamesagnew jamesagnew deleted the ja_20230416_subscription_efficiency branch April 17, 2023 12:18
jamesagnew added a commit that referenced this pull request Apr 17, 2023
* Improve subscription efficiency

* Reduce number of queries

* Add changelog

* Fix ITs

* Review comments

* Test fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants