Skip to content

R5 Subscriptions #4748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Apr 26, 2023
Merged

R5 Subscriptions #4748

merged 37 commits into from
Apr 26, 2023

Conversation

fil512
Copy link
Collaborator

@fil512 fil512 commented Apr 18, 2023

Previously, hapi-fhir converted R5 Subscriptions into R4 Subscriptions and triggered those subscriptions by resource changes in the same way R4 subscriptions are triggered. Now R5 Subscriptions are triggered based on the topic they subscribe to and the resource matching happens via the SubscriptionTopic resource. This also means that R5 Subscription endpoints are now delivered a subscription-notification Bundle as opposed to the resource as is the case with R4 Subscriptions.

@tadgh tadgh self-requested a review April 18, 2023 15:51
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.08 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (c5d3425) 81.40%.

❗ Current head c5d3425 differs from pull request most recent head dfc6d1f. Consider uploading reports for the commit dfc6d1f to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4748      +/-   ##
============================================
+ Coverage     81.32%   81.40%   +0.08%     
- Complexity    23650    24938    +1288     
============================================
  Files          1425     1530     +105     
  Lines         86399    91400    +5001     
  Branches      11677    12258     +581     
============================================
+ Hits          70265    74406    +4141     
- Misses        10947    11572     +625     
- Partials       5187     5422     +235     

see 1480 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZuSe
Copy link
Contributor

ZuSe commented Apr 24, 2023

Awesome!

@fil512 fil512 enabled auto-merge (squash) April 26, 2023 16:06
@fil512 fil512 merged commit 6b9af32 into master Apr 26, 2023
@fil512 fil512 deleted the ks-20230414-subtopic branch April 26, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants