Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make inline resource storage use a better column type #4763

Merged
merged 8 commits into from
Apr 28, 2023

Conversation

jamesagnew
Copy link
Collaborator

The inline resource storage type should use a longvarchar (ie text on postgres, varchar(max) on mssql, long on oracle, etc)

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.08 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (29d281e) 81.41%.

❗ Current head 29d281e differs from pull request most recent head 5734874. Consider uploading reports for the commit 5734874 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4763      +/-   ##
============================================
+ Coverage     81.32%   81.41%   +0.08%     
- Complexity    23650    25010    +1360     
============================================
  Files          1425     1533     +108     
  Lines         86399    91701    +5302     
  Branches      11677    12282     +605     
============================================
+ Hits          70265    74655    +4390     
- Misses        10947    11605     +658     
- Partials       5187     5441     +254     

see 1491 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jamesagnew jamesagnew merged commit 78ff582 into master Apr 28, 2023
@jamesagnew jamesagnew deleted the ja_20230422_postgres_optimization branch April 28, 2023 16:06
@stmsat
Copy link

stmsat commented Aug 30, 2023

Hello, I have a question about the mapping

//hapi-fhir-sql-migrate/src/main/java/ca/uhn/fhir/jpa/migrate/taskdef/ColumnTypeToDriverTypeToSqlType.java
		setColumnType(ColumnTypeEnum.TEXT, DriverTypeEnum.ORACLE_12C, "long");

The LONG datatype is deprecated by Oracle since LOB datatypes made their appearance, and Oracle suggests using CLOBs instead of LONGs and BLOBs instead of LONG RAWs (because LONGs have many limitations, the most dangerous and bug-prone of which is that you can have only one LONG column for each table, while you can have as many LOBs as you want).

What is the reasoning behind using the LONG datatype instead? Is there a discussion about this somewhere? I only recently took interest in the hapi-fhir project, so I apologize for asking maybe obvious questions.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants