Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post-fetch filtering to bulk export #4772

Merged
merged 6 commits into from
Apr 26, 2023

Conversation

jamesagnew
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.10 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (191b14f) 81.43%.

❗ Current head 191b14f differs from pull request most recent head 34d0e23. Consider uploading reports for the commit 34d0e23 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4772      +/-   ##
============================================
+ Coverage     81.32%   81.43%   +0.10%     
- Complexity    23650    24872    +1222     
============================================
  Files          1425     1525     +100     
  Lines         86399    91249    +4850     
  Branches      11677    12242     +565     
============================================
+ Hits          70265    74309    +4044     
- Misses        10947    11535     +588     
- Partials       5187     5405     +218     

see 1476 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@jmarchionatto jmarchionatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved with a few questions

@jamesagnew jamesagnew merged commit 855e10a into master Apr 26, 2023
@jamesagnew jamesagnew deleted the ja_20230425_bulk_export_post_fetch_filtering branch April 26, 2023 21:05
jamesagnew added a commit that referenced this pull request Apr 26, 2023
jamesagnew added a commit that referenced this pull request Apr 27, 2023
* Add post-fetch filtering to bulk export

* Add changelog

* Add validator

* Test fixes

* Test fix

* Review comments for #4772

* Commit fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants