SubscriptionTopic part3

[fil512]

• Introduce IBaseResource.isDeleted() method and convert code to use it
• Add subscription_topic_troubleshooting log
• No longer rely on ResourceGoneException to detect deleted subscription. Instead check isDeleted().
• Demote unexpected exceptions in HapiTransactionService from error to debug since these exceptions are expected e.g. when checking if a resource has been deleted by catching a ResourceGoneException

[jmarchionatto]

Nice work! Approved with a few comments

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +1.80 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (be889f8) 83.13%.

❗ Current head be889f8 differs from pull request most recent head 48d3ff2. Consider uploading reports for the commit 48d3ff2 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #4817      +/-   ##
============================================
+ Coverage     81.32%   83.13%   +1.80%     
- Complexity    23650    25293    +1643     
============================================
  Files          1425     1542     +117     
  Lines         86399    92274    +5875     
  Branches      11677    12313     +636     
============================================
+ Hits          70265    76710    +6445     
+ Misses        10947    10135     -812     
- Partials       5187     5429     +242     

see 1501 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.