Transaction with delete then update should not fail #4831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4831 +/- ##
============================================
+ Coverage 81.32% 83.13% +1.81%
- Complexity 23650 25326 +1676
============================================
Files 1425 1542 +117
Lines 86399 92373 +5974
Branches 11677 12321 +644
============================================
+ Hits 70265 76796 +6531
+ Misses 10947 10147 -800
- Partials 5187 5430 +243 ☔ View full report in Codecov by Sentry. |
…ub.com:jamesagnew/hapi-fhir into ja_20230505_transaction_with_delete_and_create
jmarchionatto
approved these changes
May 10, 2023
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirResourceDao.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirResourceDao.java
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirResourceDao.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/entity/ResourceTable.java
Show resolved
Hide resolved
hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/entity/ResourceTable.java
Outdated
Show resolved
Hide resolved
...r-jpaserver-test-r5/src/test/java/ca/uhn/fhir/jpa/dao/r5/FhirSystemDaoTransactionR5Test.java
Show resolved
Hide resolved
hapi-fhir-server/src/main/java/ca/uhn/fhir/rest/api/server/storage/TransactionDetails.java
Show resolved
Hide resolved
davidraeside
pushed a commit
that referenced
this pull request
May 15, 2023
* Fixed * Test fixes * Add test * Ongoing work * Work on xactx * Cleanup * Changelog cleanup * Resolve fixme * Rework broken APIs * Version bump * Add license headers * License header update * License * rk on fixes * Test fixes * Address review comments * Test fixes * Add license headers * License header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this mailing list discussion: https://groups.google.com/d/msgid/hapi-fhir/8c53aa54-80e2-4616-bdb0-5bc47a50eb34n%40googlegroups.com?utm_medium=email&utm_source=footer
A transaction with a delete followed by an update on the same resource currently fails. This PR fixes that, and optimizes deletes a bit too.