Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generate empty JSON element for comment #4832

Merged

Conversation

jamesagnew
Copy link
Collaborator

We should not generate an empty JSON element for comments parsed from XML

@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.80 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (6344d07) 83.12%.

❗ Current head 6344d07 differs from pull request most recent head 8ebb280. Consider uploading reports for the commit 8ebb280 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4832      +/-   ##
============================================
+ Coverage     81.32%   83.12%   +1.80%     
- Complexity    23650    25291    +1641     
============================================
  Files          1425     1542     +117     
  Lines         86399    92269    +5870     
  Branches      11677    12313     +636     
============================================
+ Hits          70265    76702    +6437     
+ Misses        10947    10138     -809     
- Partials       5187     5429     +242     

see 1501 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jamesagnew jamesagnew merged commit d5184a8 into master May 6, 2023
@jamesagnew jamesagnew deleted the ja_20230506_dont_generate_empty_json_element_for_comment branch May 6, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants