Skip to content

Fix: Replace basic field with empty value in TerserUtil #4842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 11, 2023
Merged

Fix: Replace basic field with empty value in TerserUtil #4842

merged 3 commits into from
May 11, 2023

Conversation

nigtrifork
Copy link
Contributor

@nigtrifork nigtrifork commented May 9, 2023 •
edited
Loading

I came across this bug when doing some resource merging logic.

Before the fix, TerserUtil would fail silently and log the error at debug level.

@nigtrifork nigtrifork marked this pull request as ready for review May 9, 2023 14:13
@nigtrifork
Copy link
Contributor Author

It looks like some of the tests in hapi_fhir_jpaserver_mdm are a bit flaky. It does not seem to be related to this change.

@tadgh
Copy link
Collaborator

tadgh commented May 10, 2023

It looks like some of the tests in hapi_fhir_jpaserver_mdm are a bit flaky. It does not seem to be related to this change.

Yup the MDM tests are undergoing a minor reckoning right now. Unrelated to this change.

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.80 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (c560d50) 83.13%.

❗ Current head c560d50 differs from pull request most recent head 6d07d09. Consider uploading reports for the commit 6d07d09 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #4842      +/-   ##
============================================
+ Coverage     81.32%   83.13%   +1.80%     
- Complexity    23650    25297    +1647     
============================================
  Files          1425     1542     +117     
  Lines         86399    92279    +5880     
  Branches      11677    12314     +637     
============================================
+ Hits          70265    76715    +6450     
+ Misses        10947    10136     -811     
- Partials       5187     5428     +241

see 1501 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tadgh tadgh merged commit 679b809 into hapifhir:master May 11, 2023
@tadgh
Copy link
Collaborator

tadgh commented May 11, 2023

@nigtrifork I have added credit for your fix here. Can you review this PR and ensure my description of the fix is roughly accurate? Thanks for the contribution!

#4865

jamesagnew pushed a commit that referenced this pull request May 11, 2023
@tadgh
Credit for #4842 (#4865)
9d34e6b 
* Add credit

* Typo
davidraeside pushed a commit that referenced this pull request May 15, 2023
@nigtrifork @davidraeside
Fix: Replace basic field with empty value in TerserUtil (#4842)
720f2c1 
* add test proving bug

* fix: handle empty fromValue in TerserUtil.replaceField

* add comment to TerserUtilTest.testReplaceFieldByEmptyValue
davidraeside pushed a commit that referenced this pull request May 15, 2023
@tadgh @davidraeside
Credit for #4842 (#4865)
d08f38c 
* Add credit

* Typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadgh tadgh tadgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nigtrifork @tadgh