-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Canonicalize R4 topic subscriptions #4913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…0230517-subtop-r4-backport
…0230517-subtop-r4-backport
…0230517-subtop-r4-backport
…te can be a non-null pre-resource state
…0230517-subtop-r4-backport
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4913 +/- ##
============================================
+ Coverage 81.32% 83.17% +1.84%
- Complexity 23650 25515 +1865
============================================
Files 1425 1553 +128
Lines 86399 93071 +6672
Branches 11677 12397 +720
============================================
+ Hits 70265 77409 +7144
+ Misses 10947 10207 -740
- Partials 5187 5455 +268 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some points to fix.
Approved but points should be addressed.
Added support for Topic Subscription Filters. In R4B and R5, SubscriptionTopic notifications
will interpret subscription filters as FHIR Search Parameters and perform an in-memory match of the focus resource
against the search parameters. For R4 or user-generated event notifications, the caller can specify a custom
implementation of ISubscriptionTopicFilterMatcher on the call to SubscriptionTopicDispatcher.dispatch() to provide
custom filter matching logic.
Also added support for Subscriptions R5 Backport to R4 as documented in http://build.fhir.org/ig/HL7/fhir-subscription-backport-ig/components.html.