Skip to content

Canonicalize R4 topic subscriptions #4913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
May 29, 2023
Merged

Conversation

fil512
Copy link
Collaborator

@fil512 fil512 commented May 18, 2023

Added support for Topic Subscription Filters. In R4B and R5, SubscriptionTopic notifications
will interpret subscription filters as FHIR Search Parameters and perform an in-memory match of the focus resource
against the search parameters. For R4 or user-generated event notifications, the caller can specify a custom
implementation of ISubscriptionTopicFilterMatcher on the call to SubscriptionTopicDispatcher.dispatch() to provide
custom filter matching logic.

Also added support for Subscriptions R5 Backport to R4 as documented in http://build.fhir.org/ig/HL7/fhir-subscription-backport-ig/components.html.

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.84 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (1fa2ba5) 83.17%.

❗ Current head 1fa2ba5 differs from pull request most recent head 20ce6da. Consider uploading reports for the commit 20ce6da to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4913      +/-   ##
============================================
+ Coverage     81.32%   83.17%   +1.84%     
- Complexity    23650    25515    +1865     
============================================
  Files          1425     1553     +128     
  Lines         86399    93071    +6672     
  Branches      11677    12397     +720     
============================================
+ Hits          70265    77409    +7144     
+ Misses        10947    10207     -740     
- Partials       5187     5455     +268     

see 1512 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fil512 fil512 requested review from JPercival and a team as code owners May 25, 2023 15:37
Copy link
Collaborator

@TipzCM TipzCM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some points to fix.

Approved but points should be addressed.

@fil512 fil512 enabled auto-merge (squash) May 28, 2023 22:21
@fil512 fil512 merged commit b84e8c0 into master May 29, 2023
@fil512 fil512 deleted the ks-20230517-subtop-r4-backport branch May 29, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants