Skip to content

Improve ID filtering #5215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 18, 2023
Merged

Improve ID filtering #5215

merged 5 commits into from
Aug 18, 2023

Conversation

jamesagnew
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 17, 2023

Formatting check succeeded!

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.41% 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (58b973a) 82.73%.
Report is 260 commits behind head on master.

❗ Current head 58b973a differs from pull request most recent head e210e5d. Consider uploading reports for the commit e210e5d to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5215      +/-   ##
============================================
+ Coverage     81.32%   82.73%   +1.41%     
- Complexity    23650    26244    +2594     
============================================
  Files          1425     1605     +180     
  Lines         86399   102190   +15791     
  Branches      11677    13099    +1422     
============================================
+ Hits          70265    84552   +14287     
- Misses        10947    12006    +1059     
- Partials       5187     5632     +445     

see 1615 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pepsiofficial pepsiofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, this looks good!

@jamesagnew jamesagnew enabled auto-merge (squash) August 18, 2023 15:09
@jamesagnew jamesagnew merged commit 1e45506 into master Aug 18, 2023
@jamesagnew jamesagnew deleted the ja_20230817_improve_hfql_error_msgs branch August 18, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants