Skip to content

Several IPS fixes #5297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 12, 2023
Merged

Several IPS fixes #5297

merged 7 commits into from
Sep 12, 2023

Conversation

jamesagnew
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Formatting check succeeded!

@daniellrgn
Copy link

@jamesagnew Could a fix for this line be rolled in here as well? Thymeleaf error from AllergyIntolerances missing reaction.severity (e.g. https://fhir.ips-demo.dev.cirg.uw.edu/fhir/Patient/10953/$summary)

HAPI-0389: Failed to call access method: org.thymeleaf.exceptions.TemplateProcessingException: Exception evaluating OGNL expression: "item.getSeverity().toCode()" (template: "IpsUtilityFragments" - line 184, col 23)

@jamesagnew
Copy link
Collaborator Author

@daniellrgn yup - i actually caught that one in a sweep i did this afternoon for potential NPEs, it's fixed in this PR

@jamesagnew
Copy link
Collaborator Author

@daniellrgn at least i think it is ... if you wanted to test on hapi.fhir.org that'd be awesome. All fixes in this PR are deployed there as of now.

@daniellrgn
Copy link

Thank you @jamesagnew , that seems to have done the trick!

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.46% 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (b7c937e) 82.79%.
Report is 288 commits behind head on master.

❗ Current head b7c937e differs from pull request most recent head 5a21fb4. Consider uploading reports for the commit 5a21fb4 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5297      +/-   ##
============================================
+ Coverage     81.32%   82.79%   +1.46%     
- Complexity    23650    26385    +2735     
============================================
  Files          1425     1615     +190     
  Lines         86399   102596   +16197     
  Branches      11677    13116    +1439     
============================================
+ Hits          70265    84942   +14677     
- Misses        10947    12008    +1061     
- Partials       5187     5646     +459     

see 1626 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jmarchionatto jmarchionatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved

@jamesagnew jamesagnew merged commit 03ebaba into master Sep 12, 2023
@jamesagnew jamesagnew deleted the ja_20230909_ips_fixes branch September 12, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants