Skip to content

Add support for _lanugage SP #5300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 13, 2023
Merged

Add support for _lanugage SP #5300

merged 8 commits into from
Sep 13, 2023

Conversation

jamesagnew
Copy link
Collaborator

@jamesagnew jamesagnew commented Sep 11, 2023

Fixes #5025 .

This PR adds internal support for the _language SearchParameter via a flag on StorageSettings.

@github-actions
Copy link

github-actions bot commented Sep 11, 2023

Formatting check succeeded!

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.46% 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (0232b4a) 82.79%.
Report is 292 commits behind head on master.

❗ Current head 0232b4a differs from pull request most recent head 00924fd. Consider uploading reports for the commit 00924fd to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5300      +/-   ##
============================================
+ Coverage     81.32%   82.79%   +1.46%     
- Complexity    23650    26384    +2734     
============================================
  Files          1425     1615     +190     
  Lines         86399   102611   +16212     
  Branches      11677    13119    +1442     
============================================
+ Hits          70265    84952   +14687     
- Misses        10947    12014    +1067     
- Partials       5187     5645     +458     

see 1626 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@michaelabuckley michaelabuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a question about R5 resource seeding.

@jamesagnew jamesagnew enabled auto-merge (squash) September 12, 2023 23:19
@jamesagnew jamesagnew merged commit 2da8aaf into master Sep 13, 2023
@jamesagnew jamesagnew deleted the ja_20230911_lanugage_sp branch September 13, 2023 00:35
@@ -138,6 +138,13 @@ public class StorageSettings {
* Since 6.4.0
*/
private boolean myQualifySubscriptionMatchingChannelName = true;
/**
* Should the {@literal _lamguage} SearchParameter be supported
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LAMB GAUGE: Tells you exactly how many lambs you have at any given moment

@jkiddo
Copy link
Contributor

jkiddo commented Feb 27, 2024

@jamesagnew / @tadgh I think this is missing: #5740

jkiddo added a commit to jkiddo/hapi-fhir-jpaserver-starter that referenced this pull request Feb 27, 2024
jkiddo added a commit to hapifhir/hapi-fhir-jpaserver-starter that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing support for the standard search parameter _language
4 participants