Skip to content

Fix _has then chain then _has searches #5735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 4, 2024

Conversation

lukedegruchy
Copy link
Collaborator

@lukedegruchy lukedegruchy commented Feb 23, 2024

  • Fix the Has predicate to properly handle a chain within a_has that references a _has. So for coverage.payor._has:List:item:_id it was effectively ignoring the payor part of the chain, skipping to _has:List:item:_id when it should have processed payor._has:List:item:_id instead, skipping a level of recursion and building incorrect SQL that was missing a JOIN and referencing the wrong resource type.
  • Add several new tests for various search strings containing combinations of _has and chains.

Closes: #5756

Copy link

Formatting check succeeded!

@lukedegruchy lukedegruchy marked this pull request as ready for review March 1, 2024 19:23
@lukedegruchy lukedegruchy changed the title Add SQL logging: Attempt to add test. Fix _has then chain then _has searches Mar 1, 2024
@epeartree epeartree assigned epeartree and unassigned epeartree Mar 4, 2024
Copy link
Collaborator

@epeartree epeartree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved upon changes.

@lukedegruchy lukedegruchy enabled auto-merge (squash) March 4, 2024 14:48
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.38%. Comparing base (497b9f2) to head (d7386d8).
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5735      +/-   ##
============================================
- Coverage     83.39%   83.38%   -0.02%     
+ Complexity    26927    26923       -4     
============================================
  Files          1681     1681              
  Lines        103965   103986      +21     
  Branches      13189    13189              
============================================
+ Hits          86702    86704       +2     
- Misses        11613    11630      +17     
- Partials       5650     5652       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukedegruchy lukedegruchy merged commit 4570c28 into master Mar 4, 2024
@lukedegruchy lukedegruchy deleted the ld-20240223-has-query-complex branch March 4, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search doesn't handle _has then chain then _has properly
3 participants