-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix _has then chain then _has searches #5735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Formatting check succeeded! |
…methods and clean up unnecessary code.
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/search/builder/QueryStack.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/search/builder/QueryStack.java
Outdated
Show resolved
Hide resolved
… a long comment explaining why.
… a long comment explaining why.
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/search/builder/QueryStack.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved upon changes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5735 +/- ##
============================================
- Coverage 83.39% 83.38% -0.02%
+ Complexity 26927 26923 -4
============================================
Files 1681 1681
Lines 103965 103986 +21
Branches 13189 13189
============================================
+ Hits 86702 86704 +2
- Misses 11613 11630 +17
- Partials 5650 5652 +2 ☔ View full report in Codecov by Sentry. |
_has
that references a_has
. So forcoverage.payor._has:List:item:_id
it was effectively ignoring the payor part of the chain, skipping to_has:List:item:_id
when it should have processedpayor._has:List:item:_id
instead, skipping a level of recursion and building incorrect SQL that was missing a JOIN and referencing the wrong resource type._has
and chains.Closes: #5756