Skip to content

Add extension for disabling search params#6107

Merged
jamesagnew merged 27 commits intomasterfrom
ja_20240604_allow_disable_param
Nov 7, 2024
Merged

Add extension for disabling search params#6107
jamesagnew merged 27 commits intomasterfrom
ja_20240604_allow_disable_param

Conversation

@jamesagnew
Copy link
Collaborator

This PR adds an optional extension on SearchParameter resources which can be used to prevent the SP from being used for actual searches while it's still being indexed.

@jamesagnew jamesagnew requested review from fil512 and tadgh as code owners July 12, 2024 21:03
@github-actions
Copy link

github-actions bot commented Jul 12, 2024

Formatting check succeeded!

Copy link
Collaborator

@tadgh tadgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending comments

@codecov
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.58%. Comparing base (406db33) to head (37f0975).
Report is 93 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6107      +/-   ##
============================================
+ Coverage     83.54%   83.58%   +0.03%     
- Complexity    27432    27803     +371     
============================================
  Files          1707     1740      +33     
  Lines        106185   107621    +1436     
  Branches      13397    13502     +105     
============================================
+ Hits          88710    89952    +1242     
- Misses        11750    11877     +127     
- Partials       5725     5792      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesagnew jamesagnew merged commit 96e1c2a into master Nov 7, 2024
@jamesagnew jamesagnew deleted the ja_20240604_allow_disable_param branch November 7, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants