Conversation
|
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6460 +/- ##
============================================
- Coverage 83.54% 83.45% -0.10%
- Complexity 27432 27876 +444
============================================
Files 1707 1751 +44
Lines 106185 108085 +1900
Branches 13397 13564 +167
============================================
+ Hits 88710 90197 +1487
- Misses 11750 12056 +306
- Partials 5725 5832 +107 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
michaelabuckley
left a comment
There was a problem hiding this comment.
Mostly questions.
One correctness worry. One performance worry.
Correctness - with delete entries processed before creates, do we handle delete followed by conditional-create by identifier without flush?
Performance - we have two paths to resolve ids - numeric and string. It might be faster to only use numeric if all ids are numeric, since they will also work when resolving fhir_ids. Or they could be combined into a single query like
select res_id, forced_id, res_type from hfj_resource
where res_id in (?,?,?)
or fhir_id in (?,?,?)
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/TransactionProcessor.java
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/IdHelperService.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/IdHelperService.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/IdHelperService.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/IdHelperService.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/IdHelperService.java
Outdated
Show resolved
Hide resolved
...-base/src/main/java/ca/uhn/fhir/jpa/search/builder/predicate/ResourceIdPredicateBuilder.java
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/term/TermReadSvcImpl.java
Show resolved
Hide resolved
hapi-fhir-storage/src/main/java/ca/uhn/fhir/jpa/util/MemoryCacheService.java
Outdated
Show resolved
Hide resolved
fil512
left a comment
There was a problem hiding this comment.
Nice work. Really like how much it reduces the db calls.
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/TransactionProcessor.java
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/TransactionProcessor.java
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/TransactionProcessor.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/TransactionProcessor.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/IdHelperService.java
Outdated
Show resolved
Hide resolved
...-test-r4/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoR4ReferentialIntegrityTest.java
Show resolved
Hide resolved
...est-r4/src/test/java/ca/uhn/fhir/jpa/provider/r4/ConsentInterceptorResourceProviderR4IT.java
Show resolved
Hide resolved
...r-jpaserver-test-r5/src/test/java/ca/uhn/fhir/jpa/dao/r5/FhirSystemDaoTransactionR5Test.java
Show resolved
Hide resolved
hapi-fhir-storage/src/main/java/ca/uhn/fhir/jpa/api/svc/IIdHelperService.java
Outdated
Show resolved
Hide resolved
hapi-fhir-storage/src/main/java/ca/uhn/fhir/jpa/util/MemoryCacheService.java
Show resolved
Hide resolved
fil512
left a comment
There was a problem hiding this comment.
A bunch of my comments went missing. I wonder if this will revive them...
No description provided.